jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360763133
 
 

 ##########
 File path: src/brpc/redis_reply.h
 ##########
 @@ -94,6 +122,9 @@ class RedisReply {
     // Returns PARSE_ERROR_ABSOLUTELY_WRONG if the parsing failed.
     ParseError ConsumePartialIOBuf(butil::IOBuf& buf, butil::Arena* arena);
 
+    // Serialize to iobuf appender using redis protocol
+    bool SerializeTo(butil::IOBufAppender* appender);
+
     // Swap internal fields with another reply.
     void Swap(RedisReply& other);
 
 Review comment:
   加了arena,这个实现不需要改么?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to