guodongxiaren commented on a change in pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r697883824
##########
File path: src/brpc/channel.cpp
##########
@@ -332,6 +333,7 @@ int Channel::Init(const char* ns_url,
NULL, &_options.mutable_ssl_options()->sni_name, NULL);
}
}
+ ParseServiceName(ns_url);
Review comment:
拿到的就是 `file://` ，`list://`, `consul://` 这些前缀后面的部分，我加了一个 用 `file://`
初始化channel的UT ,你可以看看。
ParseHostname就是调用了一下ParseURL，提取了 `xxx://` 之后，端口号`:` 或 路径`/`
之前的部分，作为service_name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
