zyearn commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907648462
> 因为我这个逻辑走到这里，uri.port()还是 -1 不会被 追加到Host字段中（Host只有域名）。当然Host字段中的port在Http协议中也不是必须的，不过我PR里之前修改的文档描述中写了，对方收到的Host会包含端口。所以我这里和我的文档做一下对齐。 Hi，这个改动打破backward compatibility了，不知道会有什么影响，另外文档里也说“若用户没有填且URL中包含host，比如http://www.foo.com/path，则http request中会包含"Host: www.foo.com"，我们最好可以不改这个。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
