wwbmmm commented on a change in pull request #1717:
URL: https://github.com/apache/incubator-brpc/pull/1717#discussion_r823319409
##########
File path: src/bthread/types.h
##########
@@ -83,6 +84,8 @@ typedef struct {
int destroyed;
} bthread_keytable_pool_t;
+using bthread_keytable_pool_ptr_t = std::shared_ptr<bthread_keytable_pool_t>;
Review comment:
bthread的头文件是需要兼容C的，这样就不兼容了。
另一个问题就是，把指针都改成shared_ptr，会有一些性能退化
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
