x2c3z4 commented on a change in pull request #1717:
URL: https://github.com/apache/incubator-brpc/pull/1717#discussion_r823354869
##########
File path: src/bthread/types.h
##########
@@ -83,6 +84,8 @@ typedef struct {
int destroyed;
} bthread_keytable_pool_t;
+using bthread_keytable_pool_ptr_t = std::shared_ptr<bthread_keytable_pool_t>;
Review comment:
看起来并不在 hot path 上？性能问题可能不大。C 兼容可能需要考虑一下，这个结构应该是内部结构，不暴露出去。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
