wwbmmm commented on issue #1731: URL: https://github.com/apache/incubator-brpc/issues/1731#issuecomment-1082783044
> 1. SSL_Read循环读没问题，当第1次读成功，比如读到100字节数据，而循环再读第二次时，SSL_Read返回-1，此时append_from_SSL_channel是应该返回100？还是 -1？因为毕竟读出来了100字节数据，返回-1是不是不太合适？（如果对端发送完这100字节后，对端发送RST分节，本端socket会返回-1） 这种情况就要看具体的错误原因了，你看原来代码里是区分的，如果是non fatal error，就返回已经读的字节数，并设置ssl_error。如果是fatal error，就直接返回rc。所以需要分析下当前问题是否属于non fatal error，如果是，可以扩展一下non fatal error的判断条件 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
