yanglimingcn commented on code in PR #1751:
URL: https://github.com/apache/incubator-brpc/pull/1751#discussion_r858260338


##########
src/bthread/butex.cpp:
##########
@@ -319,11 +329,13 @@ int butex_wake_all(void* arg) {
         return nwakeup;
     }
     // We will exchange with first waiter in the end.
-    ButexBthreadWaiter* next = static_cast<ButexBthreadWaiter*>(
-        bthread_waiters.head()->value());
-    next->RemoveFromList();
-    unsleep_if_necessary(next, get_global_timer_thread());
-    ++nwakeup;
+    ButexBthreadWaiter* next =
+        static_cast<ButexBthreadWaiter*>(bthread_waiters.head()->value());
+    if (!nosched) {
+        next->RemoveFromList();
+        unsleep_if_necessary(next, get_global_timer_thread());
+        ++nwakeup;
+    }
     TaskGroup* g = get_task_group(next->control);

Review Comment:
   这块已经修改了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to