wwbmmm commented on code in PR #1751:
URL: https://github.com/apache/incubator-brpc/pull/1751#discussion_r873297222
##########
src/bthread/countdown_event.h:
##########
@@ -39,7 +39,7 @@ class CountdownEvent {
void reset(int v = 1);
// Decrease the counter by |sig|
- void signal(int sig = 1);
+ void signal(int sig = 1, bool nosignal = false);
Review Comment:
这个函数叫signal，然后参数叫nosignal，感觉怪怪的。。
是不是加点注释说明一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
