chenBright commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r909554308
##########
src/brpc/socket.h:
##########
@@ -747,6 +750,10 @@ friend void DereferenceSocket(Socket*);
// Non-zero when health-checking is on.
int _health_check_interval_s;
+ // True when client SocketMap has removed socket.
+ // It can be synchronized via _versioned_ref atomic variable
+ bool _stop_health_check;
Review Comment:
socket相对比较底层，正向的话，可能要跟SocketMap或者client相关，这样也不太好。请问有什么建议吗？取xxx_flag？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
