wasphin commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r909641919
##########
src/brpc/socket.h:
##########
@@ -747,6 +750,10 @@ friend void DereferenceSocket(Socket*);
// Non-zero when health-checking is on.
int _health_check_interval_s;
+ // True when client SocketMap has removed socket.
+ // It can be synchronized via _versioned_ref atomic variable
+ bool _stop_health_check;
Review Comment:
`_stop_health_check` 是不是换成 `_health_check` 这样的好些，要不后面用时双重否定，增加了一定的理解成本
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
