wwbmmm commented on code in PR #1938:
URL: https://github.com/apache/incubator-brpc/pull/1938#discussion_r984249708
##########
tools/rpc_replay/rpc_replay.cpp:
##########
@@ -93,8 +93,8 @@ int ChannelGroup::Init() {
options.max_retry = FLAGS_max_retry;
if (chan->Init(FLAGS_server.c_str(), FLAGS_load_balancer.c_str(),
&options) != 0) {
- LOG(ERROR) << "Fail to initialize channel";
- return -1;
+ LOG(WARNING) << "Fail to initialize channel";
Review Comment:
能否先比较protocols[i].second.supported_connection_type和FLAGS_connection_type，遇到不支持的直接跳过呢。
这里Channel::Init失败可能有其它原因，比如FLAGS_server或FLAGS_load_balancer配错，这种情况如果继续往下走就不合适了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
