wwbmmm commented on code in PR #1938:
URL: https://github.com/apache/incubator-brpc/pull/1938#discussion_r984442123
##########
tools/rpc_replay/rpc_replay.cpp:
##########
@@ -83,7 +83,9 @@ int ChannelGroup::Init() {
_chans.resize(max_protocol_size + 1);
for (size_t i = 0; i < protocols.size(); ++i) {
if (protocols[i].second.support_client() &&
- protocols[i].second.support_server()) {
+ protocols[i].second.support_server() &&
+ (brpc::StringToConnectionType(FLAGS_connection_type) &
Review Comment:
brpc::StringToConnectionType可能返回CONNECTION_TYPE_UNKNOWN，需要处理下这种情况
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
