serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005599888
##########
src/brpc/builtin/prometheus_metrics_service.cpp:
##########
@@ -200,6 +200,13 @@ int DumpPrometheusMetricsToIOBuf(butil::IOBuf* output) {
return -1;
}
os.move_to(*output);
+
+ PrometheusMetricsDumper dumper_md(&os, g_server_info_prefix);
Review Comment:
是不是加个flags开关比较好？默认不输出多维度bvar。毕竟有些mbvar的维度可能比较多。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
