serverglen commented on code in PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006420523
########## src/brpc/builtin/prometheus_metrics_service.cpp: ########## @@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2); DECLARE_int32(bvar_latency_p3); } +DEFINE_bool(mvariable_dump_switch, false, "mvariable dump switch"); Review Comment: 还是新增一个flags比较好吧，如果改成FLAGS_bvar_max_dump_multi_dimension_metric_number = 0，每次都会输出WARNING日志。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
