Tuvie commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1029986626
##########
src/butil/iobuf.cpp:
##########
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) << "data_size=" << size << " is too large";
return -1;
}
+ if (!size) {
+ return 0;
Review Comment:
I still think size==0 should return -1 rather than 0. If it is failed, it
means IOBuf does not take this Block at all. It is the caller's responsibility
to delete the buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
