372046933 commented on code in PR #2009:
URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1030001048
##########
src/butil/iobuf.cpp:
##########
@@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void
(*deleter)(void*)) {
LOG(FATAL) << "data_size=" << size << " is too large";
return -1;
}
+ if (!size) {
+ return 0;
Review Comment:
@Tuvie Makes sense. Does return -1 break backward compatibility?
Also return 0 && call deleter means that IOBuf takes the responsibility to
free the buff. This is consistent with the behavior before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
