wwbmmm commented on code in PR #2280:
URL: https://github.com/apache/brpc/pull/2280#discussion_r1233465848


##########
src/brpc/controller.cpp:
##########
@@ -1173,14 +1173,16 @@ void Controller::IssueRPC(int64_t start_realtime_us) {
     wopt.ignore_eovercrowded = has_flag(FLAGS_IGNORE_EOVERCROWDED);
     int rc;
     size_t packet_size = 0;
+    // For async RPC, write to socket in background bthread to avoid blocking 
current thread.
+    bool write_in_background = _done != nullptr;

Review Comment:
   +1
   或者加个gflag控制也行



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to