MrGuin commented on code in PR #2280:
URL: https://github.com/apache/brpc/pull/2280#discussion_r1233915451
##########
src/brpc/controller.cpp:
##########
@@ -1173,14 +1173,16 @@ void Controller::IssueRPC(int64_t start_realtime_us) {
wopt.ignore_eovercrowded = has_flag(FLAGS_IGNORE_EOVERCROWDED);
int rc;
size_t packet_size = 0;
+ // For async RPC, write to socket in background bthread to avoid blocking
current thread.
+ bool write_in_background = _done != nullptr;
Review Comment:
修改了，write_in_background 作为一个选项传递给 Socket::Write，默认为
false，需要的场景可手动启用。大家再帮看一下有没有问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
