serverglen commented on code in PR #2322: URL: https://github.com/apache/brpc/pull/2322#discussion_r1269342018
########## src/bvar/mvariable.cpp: ########## @@ -36,12 +36,12 @@ DECLARE_bool(bvar_abort_on_same_name); extern bool s_bvar_may_abort; DEFINE_int32(bvar_max_multi_dimension_metric_number, 1024, "Max number of multi dimension"); -DEFINE_int32(bvar_max_dump_multi_dimension_metric_number, 0, +DEFINE_int32(bvar_max_dump_multi_dimension_metric_number, 1024, Review Comment: 1. 不建议修改gflags的默认值 2. 动态修改gflags值没问题 ########## src/bvar/mvariable.cpp: ########## @@ -36,12 +36,12 @@ DECLARE_bool(bvar_abort_on_same_name); extern bool s_bvar_may_abort; DEFINE_int32(bvar_max_multi_dimension_metric_number, 1024, "Max number of multi dimension"); -DEFINE_int32(bvar_max_dump_multi_dimension_metric_number, 0, +DEFINE_int32(bvar_max_dump_multi_dimension_metric_number, 1024, Review Comment: 1. 不建议修改gflags的默认值 2. 动态修改gflags值没问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
