lhsoft commented on code in PR #2322:
URL: https://github.com/apache/brpc/pull/2322#discussion_r1270176924
##########
src/bvar/mvariable.cpp:
##########
@@ -50,6 +50,9 @@ static bool
validator_bvar_max_multi_dimension_metric_number(const char*, int32_
const bool ALLOW_UNUSED dummp_bvar_max_multi_dimension_metric_number =
::GFLAGS_NS::RegisterFlagValidator(
&FLAGS_bvar_max_multi_dimension_metric_number,
validator_bvar_max_multi_dimension_metric_number);
+const bool ALLOW_UNUSED dummp_bvar_max_dump_multi_dimension_metric_number =
::GFLAGS_NS::RegisterFlagValidator(
+ &FLAGS_bvar_max_dump_multi_dimension_metric_number,
validator_bvar_max_multi_dimension_metric_number);
Review Comment:
这两个validator的作用应该都一样，验证是否是正整数，那我单独抽象一个吧
##########
src/bvar/mvariable.cpp:
##########
@@ -50,6 +50,9 @@ static bool
validator_bvar_max_multi_dimension_metric_number(const char*, int32_
const bool ALLOW_UNUSED dummp_bvar_max_multi_dimension_metric_number =
::GFLAGS_NS::RegisterFlagValidator(
&FLAGS_bvar_max_multi_dimension_metric_number,
validator_bvar_max_multi_dimension_metric_number);
+const bool ALLOW_UNUSED dummp_bvar_max_dump_multi_dimension_metric_number =
::GFLAGS_NS::RegisterFlagValidator(
+ &FLAGS_bvar_max_dump_multi_dimension_metric_number,
validator_bvar_max_multi_dimension_metric_number);
Review Comment:
这两个validator的作用应该都一样，验证是否是正整数，那我单独抽象一个吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
