chenBright commented on code in PR #2820:
URL: https://github.com/apache/brpc/pull/2820#discussion_r1844905089
##########
src/brpc/policy/http_rpc_protocol.cpp:
##########
@@ -1495,7 +1495,7 @@ void ProcessHttpRequest(InputMessageBase *msg) {
// NOTE: accesses to builtin services are not counted as part of
// concurrency, therefore are not limited by ServerOptions.max_concurrency.
if (!sp->is_builtin_service && !sp->params.is_tabbed) {
- if (socket->is_overcrowded() &&
!server->options().ignore_eovercrowded) {
+ if (socket->is_overcrowded() && !server->options().ignore_eovercrowded
&& !sp->ignore_eovercrowded) {
Review Comment:
同上
##########
src/brpc/policy/hulu_pbrpc_protocol.cpp:
##########
@@ -454,6 +448,12 @@ void ProcessHuluRequest(InputMessageBase* msg_base) {
sp->service->CallMethod(sp->method, cntl.get(), &breq, &bres,
NULL);
break;
}
+ if (socket->is_overcrowded() && !server->options().ignore_eovercrowded
&& !sp->ignore_eovercrowded) {
Review Comment:
同上
##########
src/brpc/policy/sofa_pbrpc_protocol.cpp:
##########
@@ -406,6 +400,11 @@ void ProcessSofaRequest(InputMessageBase* msg_base) {
meta.method().c_str());
break;
}
+ if (socket->is_overcrowded() && !server->options().ignore_eovercrowded
&& !sp->ignore_eovercrowded) {
Review Comment:
同上
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -586,6 +586,11 @@ void ProcessRpcRequest(InputMessageBase* msg_base) {
mp->service->CallMethod(mp->method, cntl.get(), &breq, &bres,
NULL);
break;
}
+ if (socket->is_overcrowded() &&
!server->options().ignore_eovercrowded && !mp->ignore_eovercrowded) {
Review Comment:
太长了，可以换一下行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
