chenBright commented on code in PR #2820:
URL: https://github.com/apache/brpc/pull/2820#discussion_r1851240114
##########
src/brpc/baidu_master_service.h:
##########
@@ -92,6 +96,7 @@ friend class Server;
MethodStatus* _status;
AdaptiveMaxConcurrency _max_concurrency;
+ bool ignore_eovercrowded = false;
Review Comment:
统一在构造函数初始化吧
##########
src/brpc/server.h:
##########
@@ -417,6 +417,12 @@ class Server {
const google::protobuf::MethodDescriptor* method;
MethodStatus* status;
AdaptiveMaxConcurrency max_concurrency;
+ // ignore_eovercrowded on method-level, it should be used with
carefulness.
+ // It might introduce inbalance between methods,
+ // as some methods(ignore_eovercrowded=1) might never return
eovercrowded
Review Comment:
ignore_eovercrowded=true/false？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
