wwbmmm commented on code in PR #2820:
URL: https://github.com/apache/brpc/pull/2820#discussion_r1862828035
##########
src/brpc/baidu_master_service.h:
##########
@@ -45,6 +45,10 @@ class BaiduMasterService : public ::google::protobuf::Service
return _max_concurrency;
}
+ bool& IgnoreEOverCrowded() {
Review Comment:
简单getter函数用下划线分隔的小写命名风格，且不需要返回引用
##########
src/brpc/server.h:
##########
@@ -595,6 +601,19 @@ class Server {
int MaxConcurrencyOf(google::protobuf::Service* service,
const butil::StringPiece& method_name) const;
+ bool& IgnoreEovercrowdedOf(const butil::StringPiece& full_method_name);
+ bool IgnoreEovercrowdedOf(const butil::StringPiece& full_method_name)
const;
+
+ bool& IgnoreEovercrowdedOf(const butil::StringPiece& full_service_name,
+ const butil::StringPiece& method_name);
+ bool IgnoreEovercrowdedOf(const butil::StringPiece& full_service_name,
+ const butil::StringPiece& method_name) const;
+
+ bool& IgnoreEovercrowdedOf(google::protobuf::Service* service,
+ const butil::StringPiece& method_name);
+ bool IgnoreEovercrowdedOf(google::protobuf::Service* service,
Review Comment:
加了这么多接口，感觉有点冗余，虽然是借鉴了上面的MaxConcurrencyOf，但IgnoreEovercrowded应该是个相对低频的功能，如果每加一个method级别的选项都这么搞，那后面接口就会膨胀得厉害。可以考虑只保留一种最方便的设置方式。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
