yanglimingcn commented on code in PR #2872: URL: https://github.com/apache/brpc/pull/2872#discussion_r1926247665
########## src/brpc/server.cpp: ########## @@ -813,14 +863,26 @@ int Server::StartInternal(const butil::EndPoint& endpoint, } return -1; } + if (opt) { - _options = *opt; + copy_server_option(_options, *opt); } else { + // Don't forget to release `rpc_pb_message_factory` before overwriting `_options` + delete _options.rpc_pb_message_factory; + _options.rpc_pb_message_factory = NULL; + Review Comment: 这个分支,也是用copy_server_option函数,感觉更好些,里面有处理delete pb_message_factory的逻辑了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org