chenBright commented on code in PR #2872:
URL: https://github.com/apache/brpc/pull/2872#discussion_r1926321757
##########
src/brpc/server.cpp:
##########
@@ -813,14 +857,26 @@ int Server::StartInternal(const butil::EndPoint& endpoint,
}
return -1;
}
+
if (opt) {
- _options = *opt;
+ copy_server_option(_options, *opt);
} else {
+ // Don't forget to release `rpc_pb_message_factory` before overwriting
`_options`
+ delete _options.rpc_pb_message_factory;
+ _options.rpc_pb_message_factory = NULL;
+
// Always reset to default options explicitly since `_options'
// may be the options for the last run or even bad options
_options = ServerOptions();
}
+ // Create the resource if:
+ // 1. `_options` copied from user and user forgot to create
+ // 2. `_options` created by our
+ if (!_options.rpc_pb_message_factory) {
+ _options.rpc_pb_message_factory = new DefaultRpcPBMessageFactory();
+ }
Review Comment:
>
仔细斟酌了一下，server启动前，不保证server.options().rpc_pb_message_factory有效的。brpc_channel_unittest的也是在server启动之后使用的，UT得适应Server的实现。所以，我认为Server构造函数里的初始化是没有必要的。
@w-gc 也看看这个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
