Just a reminder, as per [1] PR description and discussion should follow in English.
[1] https://lists.apache.org/thread/wy1p69qg1154hddwyxlf43q3oqk6owh7 Best, tison. zhoukangsheng (via GitHub) <g...@apache.org> 于2025年5月7日周三 11:25写道： > > zhoukangsheng opened a new pull request, #2964: > URL: https://github.com/apache/brpc/pull/2964 > > ### What problem does this PR solve? > > > 目前应用层的健康检查机制，是通过-health_check_path来设置，为空则不开启，但gflag是一个全局变量，一旦设置了，则对所有需要访问的下游服务全部开启了应用层的健康检查。对于一个复杂的服务来说，有可能需要调用几十甚至上百个下游服务，这些服务有可能不是brpc服务，甚至可能是go或者java服务，它们不一定全部都兼容健康检查请求，即使兼容，不同服务的请求路径也可能不一样，因此支持channel粒度设置应用层健康检查参数是有必要的。 > > > > 这个pr兼容了之前通过gflag设置健康检查请求路径和超时的功能，同时支持通过ChannelOptions中health_check_path和health_check_timeout_ms来设置健康检查参数，ChannelOptions中的参数优先级要高于gflag，若ChannelOptions中参数未设置，则按gflag设置值生效。 > > Issue Number: > > Problem Summary: > > ### What is changed and the side effects? > no > Changed: > > Side effects: > - Performance effects: > no > - Breaking backward compatibility: > no > --- > ### Check List: > - Please make sure your changes are compilable. > - When providing us with a new feature, it is best to add related tests. > - Please follow [Contributor Covenant Code of Conduct]( > https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > >
