wwbmmm commented on code in PR #2964:
URL: https://github.com/apache/brpc/pull/2964#discussion_r2082956053
##########
src/brpc/details/health_check.cpp:
##########
@@ -65,6 +57,8 @@ class OnAppHealthCheckDone : public google::protobuf::Closure
{
SocketId id;
int64_t interval_s;
int64_t last_check_time_ms;
+ int32_t health_check_timeout_ms;
Review Comment:
These can be replaced into HealthCheckOption too.
##########
src/brpc/channel.h:
##########
@@ -36,6 +36,7 @@
#include "brpc/retry_policy.h"
#include "brpc/backup_request_policy.h"
#include "brpc/naming_service_filter.h"
+#include "brpc/socket.h"
Review Comment:
I think the `HealthCheckOption` is better to be defined in a separate
header file, like `ChannelSSLOptions` defined in `ssl_options.h`. So that you
can avoid importing the unrelated classes and headers in `socket.h` here.
##########
src/brpc/socket.h:
##########
@@ -980,6 +992,8 @@ friend void DereferenceSocket(Socket*);
int _tcp_user_timeout_ms;
HttpMethod _http_request_method;
+ std::string _health_check_path;
Review Comment:
These can be replaced into `HealthCheckOption` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
