Q1ngbo commented on code in PR #3062:
URL: https://github.com/apache/brpc/pull/3062#discussion_r2273314181
##########
src/butil/iobuf.cpp:
##########
@@ -1976,6 +1976,259 @@ size_t IOBufCutter::cutn(void* out, size_t n) {
}
}
+SingleIOBuf::SingleIOBuf()
Review Comment:
I agree that. But to do this properly, we would need to refactor iobuf.h
and iobuf.cpp—for example, moving the definition of IOBuf::Block into iobuf.h
and adding declarations of the butil::iobuf functions from iobuf.cpp. This
would involve fairly substantial changes to these files.
Could you please confirm if such a level of modification is acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
