wwbmmm commented on code in PR #3062:
URL: https://github.com/apache/brpc/pull/3062#discussion_r2275189337
##########
src/butil/iobuf.cpp:
##########
@@ -1976,6 +1976,259 @@ size_t IOBufCutter::cutn(void* out, size_t n) {
}
}
+SingleIOBuf::SingleIOBuf()
Review Comment:
Yes, that's acceptable. I think you can move the definition of IOBuf::Block
and butil::iobuf functions to iobuf_inl.h, not iobuf.h, because they are not
user interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
