ZhengweiZhu commented on PR #3096: URL: https://github.com/apache/brpc/pull/3096#issuecomment-3409796206
> > The comments have all been resolved. But there's one problem left, that's when the bthread status is set to TASK_STATUS_READY, the actual status is set to TASK_STATUS_FIRST_READY. > > https://github.com/apache/brpc/blob/07083331e1496746f4b1cfa54d0b6364f321be34/src/bthread/task_tracer.cpp#L150-L154 > > > > so the following judgement will never meet? > > https://github.com/apache/brpc/blob/07083331e1496746f4b1cfa54d0b6364f321be34/src/bthread/task_tracer.cpp#L257-L259 > > > > According to my test, there seems to always exist a bthread in TASK_STATUS_FIRST_READY status and not traceable. This bthread has flag 320 which means "BTHREAD_NEVER_QUIT | BTHREAD_GLOBAL_PRIORITY" , which seems to be EventDispatcher? Is this expected? <img alt="image" width="487" height="309" src="https://private-user-images.githubusercontent.com/141622927/501839753-48b85a49-9812-448a-8da4-801938194546.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjA2MDI3MjksIm5iZiI6MTc2MDYwMjQyOSwicGF0aCI6Ii8xNDE2MjI5MjcvNTAxODM5NzUzLTQ4Yjg1YTQ5LTk4MTItNDQ4YS04ZGE0LTgwMTkzODE5NDU0Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAxNlQwODEzNDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZjg0YjUyNjg1ZTNmNjBhOTEzZTZiZDdmMzVhNTJlZTYyYjQyOWI0NmFkODk2OWE0Y2Y3ZWJmMDc 0ZDg5ZDQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.oRRR8CQKN5CQUcQKsEf2MuUf-eN7MsuO5CfpSh0KIAQ"> > > @chenBright > > It should be `if (TASK_STATUS_READY == s && NULL == m->stack)`, please fix it. Fixed! BTW fix another _enable_priority_queue not initialized bug. 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
