ZhengweiZhu commented on code in PR #3096:
URL: https://github.com/apache/brpc/pull/3096#discussion_r2423750475
##########
src/bthread/task_group.cpp:
##########
@@ -1127,7 +1135,9 @@ void print_task(std::ostream& os, bthread_t tid) {
}
}
if (!matched) {
- os << "bthread=" << tid << " : not exist now";
+ if (!ignore_not_matched) {
Review Comment:
> I don't understand the function of ignore_not_matched here. I think when
the tid and version_butex not match, it indicates that the bthread is not
living.
Yes, when the tid and version_butex not matches, it indicates the bthread is
not living and should not be printed. Without this ignore_not_matched
judgement, it will print `bthread=xxx : not exist now`, which is not what I
want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
