chenBright commented on code in PR #3096:
URL: https://github.com/apache/brpc/pull/3096#discussion_r2423403956
##########
src/bthread/task_group.cpp:
##########
@@ -1145,8 +1156,15 @@ void print_task(std::ostream& os, bthread_t tid) {
<< "\nstatus=" << status
<< "\ntraced=" << traced
<< "\nworker_tid=" << worker_tid;
-#else
- ;
+ if (enable_trace) {
+ os << "\nbthread call stack:\n";
+ stack_trace(os, tid);
+ os << "\n\n";
+ } else {
+ os << "\n\n";
+ }
Review Comment:
```c++
if (enable_trace) {
os << "\nbthread call stack:\n";
stack_trace(os, tid);
}
os << "\n\n";
```
##########
src/bthread/task_control.h:
##########
@@ -28,6 +28,7 @@
#include <signal.h>
#include <stddef.h> // size_t
#include <vector>
+#include <set>
Review Comment:
unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
