wwbmmm commented on code in PR #3124:
URL: https://github.com/apache/brpc/pull/3124#discussion_r2458419454
##########
src/bthread/task_tracer.h:
##########
@@ -115,6 +118,7 @@ class TaskTracer {
std::vector<butil::intrusive_ptr<SignalSync>> _inuse_signal_syncs;
bvar::LatencyRecorder _trace_time{"bthread_trace_time"};
+ int _signal_num{SIGURG};
Review Comment:
I think you can directly use FLAGS_signal_number_for_trace everywhere, don't
need to add this class member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
