wwbmmm commented on code in PR #3124:
URL: https://github.com/apache/brpc/pull/3124#discussion_r2459196285


##########
src/bthread/task_tracer.h:
##########
@@ -115,6 +118,7 @@ class TaskTracer {
     std::vector<butil::intrusive_ptr<SignalSync>> _inuse_signal_syncs;
 
     bvar::LatencyRecorder _trace_time{"bthread_trace_time"};
+    int _signal_num{SIGURG};

Review Comment:
   > Both way works. This is to guarantee the signal number is immutable. 
Should I change?
   
   That make sense. You don't need to change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to