lh2debug commented on code in PR #3140:
URL: https://github.com/apache/brpc/pull/3140#discussion_r2522266344
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -269,9 +269,9 @@ struct BaiduProxyPBMessages : public RpcPBMessages {
// Used by UT, can't be static.
void SendRpcResponse(int64_t correlation_id, Controller* cntl,
RpcPBMessages* messages, const Server* server,
- MethodStatus* method_status, int64_t received_us) {
+ MethodStatus* method_status, int64_t received_us,
+ std::shared_ptr<Span> span) {
Review Comment:
SendRpcResponse needs to hold a strong reference count; otherwise, if the
backend spancontainer releases the reference, the server span will be unable to
set_start_send_us and set_response_size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
