lh2debug commented on code in PR #3140:
URL: https://github.com/apache/brpc/pull/3140#discussion_r2522464644
##########
src/bthread/key.cpp:
##########
@@ -405,6 +417,11 @@ static void cleanup_pthread(void* arg) {
delete kt;
// After deletion: tls may be set during deletion.
tls_bls.keytable = NULL;
+
Review Comment:
`rpcz_parent_span` is a void* protocol field (type controlled by brpc) in
bthread TLS that points to `weak_ptr<Span>`.
`key.cpp` is responsible for its lifecycle triggering points
(creation/destruction/end) and is decoupled from the specific implementation of
brpc (`span.cpp`) through a global callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
