chenBright commented on code in PR #3163:
URL: https://github.com/apache/brpc/pull/3163#discussion_r2573029496
##########
src/brpc/controller.cpp:
##########
@@ -1542,6 +1660,9 @@ void
Controller::ReadProgressiveAttachmentBy(ProgressiveReader* r) {
__FUNCTION__));
}
add_flag(FLAGS_PROGRESSIVE_READER);
+ if (progressive_read_timeout_ms() > 0) {
+ return _rpa->ReadProgressiveAttachmentBy(new
ProgressiveTimeoutRead(this, r));
Review Comment:
> Then we don't need to hold the controller in the ProgressiveTimeoutRead
Agreed. The controller may have been destroyed and can no longer be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
