wwbmmm commented on code in PR #3163:
URL: https://github.com/apache/brpc/pull/3163#discussion_r2584369115
##########
src/brpc/controller.cpp:
##########
@@ -1028,6 +1118,44 @@ void Controller::SubmitSpan() {
_span = NULL;
}
+void Controller::HandleIdleProgressiveReader(void* arg) {
Review Comment:
Since this function don't access Controller now, it no longer need to be a
member of Controller.
##########
src/brpc/progressive_reader.h:
##########
@@ -84,6 +85,8 @@ class ReadableProgressiveAttachment : public SharedObject {
// Any error occurred should destroy the reader by calling r->Destroy().
// r->Destroy() should be guaranteed to be called once and only once.
virtual void ReadProgressiveAttachmentBy(ProgressiveReader* r) = 0;
+ virtual SocketId GetSocketId() = 0;
+ virtual void SetSocketId(SocketId id) = 0;
Review Comment:
The ReadableProgressiveAttachment interface doesn't need a virtual
SetSocketId function.
The SetSocketId function can be only a member of HttpContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
