rajvarun77 commented on code in PR #3323:
URL: https://github.com/apache/brpc/pull/3323#discussion_r3352703577
##########
.github/workflows/ci-linux.yml:
##########
@@ -214,10 +220,19 @@ jobs:
cat config.mk
cd test
make NEED_GPERFTOOLS=0 -j ${{env.proc_num}}
+ - name: install redis-server and mysql-server
+ run: |
+ sudo apt-get update
+ sudo apt-get install -y redis-server mysql-server
+ redis-server --version
+ mysqld --version
- name: run tests
run: |
cd test
- sh ./run_tests.sh
+ # brpc_redis_unittest forks a real redis-server and waits a fixed 50ms
before
+ # connecting; under ASan redis starts too slowly, so the redis client
tests are
+ # flaky here (connection refused). Skip them in ASan; they run in
clang-unittest.
+ GTEST_FILTER='-RedisTest.*' sh ./run_tests.sh
clang-unittest-bazel-with-babylon-and-new-pb:
Review Comment:
Done — addressed in the latest commit. `gcc-unittest-with-bazel`,
`clang-unittest-with-bazel`, and `clang-unittest-bazel-with-babylon-and-new-pb`
now pull in the `install-essential-dependencies` action, and
`brpc_redis_unittest` is tagged `external` + `local` so it runs unsandboxed
(where the PATH-located `redis-server` is visible and loopback works) and
re-runs rather than serving a cached pass.
The Redis integration tests now genuinely fork `redis-server` and run under
Bazel — confirmed from the logs of the latest green **Build and Test on Linux**
run: the forked `redis-server` reaches `Ready to accept connections`, and
`RedisTest.sanity` / `keys_with_spaces` / `incr_and_decr` / `by_components` /
`auth` all pass (not skipped, not cached).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
