rajvarun77 commented on PR #3323: URL: https://github.com/apache/brpc/pull/3323#issuecomment-4617866295
All review feedback is addressed and CI is green — ready for another look. - **Redis** client tests now actually run under both the make and the Bazel unittest jobs — via the shared `install-essential-dependencies` action plus the `external` + `local` tags on `brpc_redis_unittest`. Verified from the logs of the latest green **Build and Test on Linux** run: the forked `redis-server` reaches `Ready to accept connections` and the five client cases (`sanity`, `keys_with_spaces`, `incr_and_decr`, `by_components`, `auth`) pass rather than skip. - **MySQL**: `mysql-server` is pre-provisioned for the in-progress MySQL protocol support (#2093); its client tests land in that follow-up. The PR description has been updated to state this accurately. - **ASan** filters only the five fork-and-connect Redis cases; the Redis codec/parser tests still run. Thanks @chenBright for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
