rajvarun77 commented on PR #3330: URL: https://github.com/apache/brpc/pull/3330#issuecomment-4626536107
@chenBright @wwbmmm — marking this ready for review. Full MySQL client protocol for brpc — COM_QUERY text protocol, interactive transactions, and prepared statements — built on a **clean-room** authentication codec (no GPL lineage), addressing #2093. - **Auth (clean-room):** `mysql_native_password` + `caching_sha2_password` (fast-auth + full-auth RSA / secure-transport cleartext), derived from the public MySQL protocol docs. - **Minimal shared-core footprint (redis-like):** the only generic `Controller`/`Socket` additions are a socket reserve/use hook + `fd_version` (ABA guard) for transaction/prepared-statement affinity, an auth empty-write guard for the server-greets-first handshake, and protocol registration. No protocol-specific type lives on the shared `Controller`. - **Tests:** clean-room integration tests (transactions, prepared statements, pooled-connection concurrency, connection-type, binary TIME/DATETIME) run against a self-spawned `mysqld` — 20/20 passing locally; a standalone 30-case end-to-end run was independently verified. The clean-room auth codec is also up as a smaller, focused PR (#3310, Stage 1a) if you'd prefer to review that foundation first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
