rajvarun77 commented on PR #3330: URL: https://github.com/apache/brpc/pull/3330#issuecomment-4676082368
Moved all seven MySQL unittests from `test/mysql/` into `test/` (following the review on #3310), so the existing `brpc_*_unittest` glob picks them up. `test/Makefile`, `test/CMakeLists.txt`, and `test/run_tests.sh` revert to master with no mysql-specific lines. In `test/BUILD.bazel` the files join the `brpc_unittests` glob; the five tests that fork a real `mysqld` keep their `["external", "local"]` tags by folding those entries into that target's `per_test_tags` (rather than a separate mysql target). All seven tests compile and run green in the unittest jobs — auth handshake 28 / packet 27 / scramble 35, plus connection-type, pool-concurrency, prepared, and txn integration. Any remaining red is a pre-existing unrelated flake (`brpc_channel_unittest`/`brpc_load_balancer_unittest` timeouts, `SocketTest`, `EventDispatcherTest` under ASan), not this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
