darion-yaphet opened a new pull request, #3400:
URL: https://github.com/apache/brpc/pull/3400
## Summary
- Remove the `COMMON_VARIABLE_CONSTRUCTOR` macro
- Replace its uses in the Babylon counter variants of `Adder`, `Maxer`,
`Miner`, and `IntRecorder` with explicit constructors
- Preserve the existing constructor behavior for default construction,
`expose(name)`, and `expose_as(prefix, name)`
## Motivation
`COMMON_VARIABLE_CONSTRUCTOR` hid public constructors behind macro
expansion, making the code harder to read, search, and navigate with regular
C++ tooling.
This change keeps the API behavior unchanged while making the constructors
visible at their declaration sites.
`using Base::Base` was intentionally avoided because it would expose
additional internal base constructors in the Babylon counter path and could
broaden the public
API.
## Testing
- `cmake --build build --target brpc-static -j6`
- `git diff --check`
- `rg COMMON_VARIABLE_CONSTRUCTOR . -g '!build/**'`
## Notes
The `WITH_BABYLON_COUNTER` path was not compiled locally because the
available Bazel setup is missing the repository-required Bazel `7.2.1` binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
