darion-yaphet commented on PR #3400: URL: https://github.com/apache/brpc/pull/3400#issuecomment-5086780538
> > I think this is to simplify the code, which is fine, like the DISALLOW_COPY_AND_ASSIGN macro. > > Agree I agree the macro reduces a few lines, but it hides public constructors, which are part of the API surface and important for readability/tooling. Since these constructors are simple and type-specific, spelling them out makes the public interface clearer. That said, because variable.h is installed as a public header, removing the macro may break downstream users. I can keep a deprecated compatibility definition for one release while removing internal usages, then remove it in a later breaking-change cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
