wwbmmm commented on PR #3408: URL: https://github.com/apache/brpc/pull/3408#issuecomment-5126973010
> My main concern is the older MesaLink/old-OpenSSL backward compatibility break. Otherwise LGTM > > Is there anything we can do to avoid it? Maybe a flag so existing users won't be silently broken? This will only affect users who set verify.verify_depth > 0 && verify.verify_mode != VerifyMode::VERIFY_NONE . I think they need to verify the peer host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
