wwbmmm commented on PR #3408: URL: https://github.com/apache/brpc/pull/3408#issuecomment-5127978191
> My main concern is the older MesaLink/old-OpenSSL backward compatibility break. Otherwise LGTM > > Is there anything we can do to avoid it? Maybe a flag so existing users won't be silently broken? You are right. I’ve updated the PR to preserve backward compatibility: * OpenSSL 1.0.2+ and BoringSSL automatically verify the HTTPS URL host. * MesaLink and older OpenSSL retain chain-only verification and emit a one-time warning. * Explicitly setting expected_peer_name still fails on unsupported backends instead of being silently ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
