wasphin commented on code in PR #3430:
URL: https://github.com/apache/brpc/pull/3430#discussion_r3751099436
##########
test/brpc_http_rpc_protocol_unittest.cpp:
##########
@@ -1554,15 +1556,15 @@ TEST_F(HttpTest, http2_window_used_up) {
NULL, &cntl, request_buf, NULL);
butil::IOBuf dummy;
butil::Status st = socket_message->AppendAndDestroySelf(&dummy,
_h2_client_sock.get());
+ ASSERT_TRUE(st.ok());
if (i == nsuc) {
- // the last message should fail according to flow control policy.
- ASSERT_FALSE(st.ok());
- ASSERT_TRUE(st.error_code() == brpc::ELIMIT);
-
ASSERT_TRUE(butil::StringPiece(st.error_str()).starts_with("remote_window_left
is not enough"));
+ ASSERT_GT(ctx->_pending_data_size, 0u);
+ h2_req->DestroyStreamUserData(
+ _h2_client_sock, &cntl, ECANCELED, false);
+ ASSERT_EQ(0u, ctx->_pending_data_size);
Review Comment:
See comments above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
