wasphin commented on code in PR #3430: URL: https://github.com/apache/brpc/pull/3430#discussion_r3751097538
########## test/brpc_h2_unsent_message_unittest.cpp: ########## @@ -27,11 +27,211 @@ #include "brpc/policy/http2_rpc_protocol.h" #include "gperftools_helper.h" Review Comment: The unit-test targets are compiled with `-fno-access-control`, which allows existing protocol tests to inspect internal state. The CMake, Clang, GCC, ASan, and Bazel checks are passing with these assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
