zchuango opened a new pull request, #3469:
URL: https://github.com/apache/brpc/pull/3469

   ### What problem does this PR solve?
   
   Issue Number: Related to #3133, follow-up pr #3409 and #3453
   
   Problem Summary:
   
   Progressive HTTP response reads currently have no independent idle timeout 
after `ReadProgressiveAttachmentBy()` is called. A reader may therefore wait 
indefinitely when the peer stops sending body data while keeping the connection 
open.
   
   PR #3409 introduced progressive-read timeout support, but post-merge CI 
exposed a lifecycle and synchronization problem around the timer callback and 
reader completion path. In particular, the timer callback could race with 
reader completion/error delivery, which made 
`HttpTest.progressive_read_timeout_preserves_reader_error` unstable and could 
replace the reader's original error with the timeout status.
   
   This PR restores the feature with explicit synchronization and independent 
timer-state ownership.
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to