Copilot commented on code in PR #3469: URL: https://github.com/apache/brpc/pull/3469#discussion_r3827835903
########## example/http_c++/http_client.cpp: ########## @@ -22,11 +22,17 @@ // - Access www.foo.com // ./http_client www.foo.com +#include <string> #include <gflags/gflags.h> #include <butil/logging.h> #include <brpc/channel.h> +#include "bthread/countdown_event.h" Review Comment: This file uses std::cout/std::cerr but does not include <iostream>. Relying on transitive includes can break builds when headers change; include the standard header explicitly. ########## example/http_c++/http_server.cpp: ########## @@ -31,6 +31,7 @@ DEFINE_int32(idle_timeout_s, -1, "Connection will be closed if there is no " DEFINE_string(certificate, "cert.pem", "Certificate file path to enable SSL"); DEFINE_string(private_key, "key.pem", "Private key file path to enable SSL"); DEFINE_string(ciphers, "", "Cipher suite used for SSL connections"); +DEFINE_bool(enable_progressive_timeout, false, "whether or not trigger progressive write attachment data timeout"); Review Comment: The flag help text says it triggers a "progressive write attachment data timeout", but the code actually simulates a long stall mid-stream (to help reproduce client-side progressive *read* idle timeout). Updating the help string will make the example less confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
